fix: added a len check before draining#3630
fix: added a len check before draining#3630mohan-bee wants to merge 2 commits intoGraphiteEditor:masterfrom
Conversation
|
@adamgerhant review pls ! |
|
When we do this with a Vec2 Value, this error is the expected outcome: 
In your video, we see something different: 
This is not the expected behavior. It likely means your initial approach is masking the underlying problem instead of tracing back to its root cause. |
|
@Keavon i have added default unit value input so that the identity node can function properly. |
| if node.inputs.len() > 1 { | ||
| node.inputs.drain(1..); | ||
| } else if node.inputs.is_empty() { | ||
| node.inputs.push(NodeInput::value(TaggedValue::None, false)); |
There was a problem hiding this comment.
If a node with no inputs is hidden, the identity node value should be based on the output type. This can be represented by changing the visible field on DocumentNode to store an enum like
pub enum Visible {
Passthrough,
Value(Type),
}
Then in the editor, when hiding the node, if the node has no inputs it gets set the the Value variant with the Type based on the output type of that node. This Type is then used to construct the tagged value, instead of using TaggedValue::None.
3 participants
fixes #3629
issue: node.inputs tries to drain from the index 1 which causes the crash
fix: added a len check before draining
before:
Screen.Recording.2026-01-13.at.11.02.05.AM.mov
after:
Screen.Recording.2026-01-13.at.11.00.56.AM.mov